Need reviewer for forward port of 6815768 (File.getXXXSpace) and 6815768 (String.hashCode)

Andrew John Hughes gnu_andrew at member.fsf.org
Thu Feb 25 18:58:35 UTC 2010


On 25 February 2010 18:19, Kelly O'Hair <Kelly.Ohair at sun.com> wrote:
> Looks fine to me.
>
> -kto
>
> On 2/25/10 9:51 AM, Alan Bateman wrote:
>>
>> There are two fixes in Sun's proprietary jdk6 updates that should also
>> be fixed in OpenJDK.
>>
>> The first one is that the File.getXXXSpace methods use statvfs instead
>> of statvfs64 and so fail on 32-bit Solaris and Linux with very large
>> file systems. The webrev is here:
>> http://cr.openjdk.java.net/~alanb/6815768/webrev.00/
>> The GetXSpace test already covers these methods and an additional test
>> isn't required.
>>
>> The second one is a scalability fix to String.hashCode to avoid storing
>> the hash code of empty strings. The webrev with the change is here:
>> http://cr.openjdk.java.net/~alanb/6815768/webrev/
>>
>> Thanks,
>> Alan.
>

Joe, ok for 6 too?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the core-libs-dev mailing list