Review patches isBMPCodePoint/2/3

Martin Buchholz martinrb at google.com
Thu Mar 25 21:27:55 UTC 2010


On Thu, Mar 25, 2010 at 06:41, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
> Am 23.03.2010 19:19, schrieb Martin Buchholz:
>>
>> Ulf,
>>
>> Please do not delete methods in Surrogate.java
>> (because we take compatibility seriously)
>>
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint
>
> I still think, we should stick on Surrogate#isBMP for above compatibility
> reason.
> Otherwise we too should rename #neededFor etc.

The difference is that isBMP was not provided with any officially supported JDK
(i.e. Sun JDK 6).  We take compatibility seriously, but not that seriously :)

> Please add @author Ulf Zibis

$ rg -l '@author.*Zibis'
./src/share/classes/java/lang/Character.java
./src/share/classes/java/lang/AbstractStringBuilder.java
./src/share/classes/java/lang/String.java
./src/share/classes/sun/nio/cs/Surrogate.java

> and correct copyright date.

I leave that up to the Sun release engineers.

Martin



More information about the core-libs-dev mailing list