Review patches isBMPCodePoint/2/3

Ulf Zibis Ulf.Zibis at gmx.de
Thu Mar 25 22:36:05 UTC 2010


Am 25.03.2010 22:27, schrieb Martin Buchholz:
> On Thu, Mar 25, 2010 at 06:41, Ulf Zibis<Ulf.Zibis at gmx.de>  wrote:
>    
>> Am 23.03.2010 19:19, schrieb Martin Buchholz:
>>      
>>> Ulf,
>>>
>>> Please do not delete methods in Surrogate.java
>>> (because we take compatibility seriously)
>>>
>>>        
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint
>>
>> I still think, we should stick on Surrogate#isBMP for above compatibility
>> reason.
>> Otherwise we too should rename #neededFor etc.
>>      
> The difference is that isBMP was not provided with any officially supported JDK
> (i.e. Sun JDK 6).  We take compatibility seriously, but not that seriously :)
>    

You're right.
So we can make it private, and no one would come to the idea to use it 
in-advisedly.

> $ rg -l '@author.*Zibis'
> ./src/share/classes/java/lang/Character.java
> ./src/share/classes/java/lang/AbstractStringBuilder.java
> ./src/share/classes/java/lang/String.java
> ./src/share/classes/sun/nio/cs/Surrogate.java
>    

Thanks,

-Ulf





More information about the core-libs-dev mailing list