Please review java.util.jar.pack.* cleanup/refactoring/generificaiton

[Kumar Srinivasan]

> So some of these changes are using the new jdk7 language features? 
> (diamond operator)
> Is this a first, or is this happening already? Just curious.
decided to use it,  put NB on autopilot. :-)
>
> http://cr.openjdk.java.net/~ksrini/6990106/webrev.00/src/share/classes/com/sun/java/util/jar/pack/Attribute.java.sdiff.html 
>
>  460             return (layout == null ? "" == null : 
> layout.equals(""));
>    I'd use       return "".equals(layout);

Will fix it.

Thanks

Kumar

>
> I wasn't able to look at much more, I'll try to later...  Just thought 
> I'd pass on what I saw.
>
> -kto
>
> On Nov 11, 2010, at 9:29 AM, Kumar Srinivasan wrote:
>
>> Hi,
>>
>> Appreciate a review of the pack200 cleanup work, in the following areas:
>>
>> 1. General generification of Collections.
>> 2. fixed worthy findbugs items.
>> 3. fixed worthy Netbeans nags.
>> 4. Elimination of array/generics combination.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~ksrini/6990106/webrev.00/
>>
>> Thanks
>> Kumar
>>
>