Please review java.util.jar.pack.* cleanup/refactoring/generificaiton

[Rémi Forax]

Le 11/11/2010 20:34, Kelly O'Hair a écrit :
> So some of these changes are using the new jdk7 language features? 
> (diamond operator)
> Is this a first, or is this happening already? Just curious.

It's not the first time. I have seen it time to time.
Mark (Reinhold) was the first to push a patch using the diamond operator 
in jigsaw tree.

>
> http://cr.openjdk.java.net/~ksrini/6990106/webrev.00/src/share/classes/com/sun/java/util/jar/pack/Attribute.java.sdiff.html 
>
>  460             return (layout == null ? "" == null : 
> layout.equals(""));
>    I'd use       return "".equals(layout);
>
> I wasn't able to look at much more, I'll try to later...  Just thought 
> I'd pass on what I saw.
>
> -kto

Rémi