Code review request for 6543593 "(reflect) Clarify private final field mutability"
Joe Darcy
joe.darcy at oracle.com
Mon Apr 4 17:04:22 UTC 2011
Alan Bateman wrote:
> Joe Darcy wrote:
>>
>> Fair enough. How about just for the setter methods
>>
>> + * @exception IllegalAccessException if this {@code Field}
>> object
>> + * enforces Java language access control and the
>> underlying
>> + * field is inaccessible or is final.
> I think a comma before the "and" would make this a bit clearer (as the
> two conjunctions might force the reader to read it more than once to
> get the meaning).
>
> -Alan.
How about for the setters
* @exception IllegalAccessException if this {@code Field} object
* enforces Java language access control and the underlying
* field is either inaccessible or final.
Updated webrev at
http://cr.openjdk.java.net/~darcy/6543593.1/
Thanks,
-Joe
More information about the core-libs-dev
mailing list