Code review request for 4900206 "Include worst-case rounding tests for Math library functions"
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 11 14:20:03 UTC 2011
Joe Darcy wrote:
> Hello.
>
> Cleaning up my bug backlog, please review the addition of some new
> math library tests:
>
> 4900206 "Include worst-case rounding tests for Math library
> functions"
> http://cr.openjdk.java.net/~darcy/4900206.0/
>
> These tests probe at hard to round values generated by
> number-theoretic techniques. I've verified the tests pass on Linux
> x86 and Solaris sparc.
>
> Thanks,
>
> -Joe
This looks good to me (I didn't of course check each case against the
results on the JMD site). One small suggestion is to mention in the
comment that its based on teh Sep 5, 2000 update on the off chance that
new cases are added and we find ourselves wondering if the test is up to
date.
-Alan.
More information about the core-libs-dev
mailing list