Code review request for 4900206 "Include worst-case rounding tests for Math library functions"

Joe Darcy joe.darcy at oracle.com
Thu Aug 11 21:58:26 UTC 2011


Hi Alan.

On 8/11/2011 7:20 AM, Alan Bateman wrote:
> Joe Darcy wrote:
>> Hello.
>>
>> Cleaning up my bug backlog, please review the addition of some new 
>> math library tests:
>>
>>     4900206 "Include worst-case rounding tests for Math library 
>> functions"
>>     http://cr.openjdk.java.net/~darcy/4900206.0/
>>
>> These tests probe at hard to round values generated by 
>> number-theoretic techniques.  I've verified the tests pass on Linux 
>> x86 and Solaris sparc.
>>
>> Thanks,
>>
>> -Joe
> This looks good to me (I didn't of course check each case against the 
> results on the JMD site). One small suggestion is to mention in the 
> comment that its based on teh Sep 5, 2000 update on the off chance 
> that new cases are added and we find ourselves wondering if the test 
> is up to date.
>
> -Alan.
>

I've revised and augmented  tests in a few ways.  I've added more test 
cases from some more recent work on the team in question and included a 
URL to that paper.  Additionally, following an off-list suggestion from 
you, I've added @run tag using the Xcomp option.

New webrev is here:

     http://cr.openjdk.java.net/~darcy/4900206.1/

Thanks,

-Joe




More information about the core-libs-dev mailing list