Code Review Request for Bug #7069190

[David Holmes]

On 1/12/2011 9:23 AM, Xueming Shen wrote:
> (1) you might need to consider the use scenario of an unset HOME env
> (2) it appears to be an in-compatible change if the values from getpwuid
> and
> from HOME are different (understood this is what you want to address),
> in which
> I think might need a CCC review (for the possible in-compatible change
> of behavior)

Yes at a minimum this should go to CCC to assess whether it should be 
changed (there's been some side-channel email on this). There are a lot 
of potential issues with this proposed change.

David

>
> -Sherman
>
> On 11/30/2011 2:23 PM, Darryl Mocek wrote:
>> Wrong webrev link. Here's the correct one:
>> http://cr.openjdk.java.net/~dmocek/7069190/webrev.00
>>
>> Darryl
>>
>> On 11/30/2011 02:16 PM, Darryl Mocek wrote:
>>> Hello. Please review this patch to fix the getting of the user's home
>>> setting using System.getProperty("user.home") on UNIX's. The previous
>>> implementation used getpwuid, which didn't allow the user to set the
>>> value in the environment.
>>>
>>> Webrev, can be found here:
>>> http://cr.openjdk.java.net/~darryl/7069190/webrev.00
>>>
>>> Thanks,
>>> Darryl