Code Review Request for Bug #7069190
Alan Bateman
Alan.Bateman at oracle.com
Thu Dec 1 09:07:18 UTC 2011
On 30/11/2011 22:23, Darryl Mocek wrote:
> Wrong webrev link. Here's the correct one:
> http://cr.openjdk.java.net/~dmocek/7069190/webrev.00
As Sherman and David said, we need to think through any potential
compatibility issues (it may be the right thing to do but is there any
potential to break something?). Also should we be looking at LOGNAME or
USER to get the value of the user.name property and so avoid looking up
the password entry? We've had issues with folks with odd configurations
where the value of the user.name or user.home properties defaults "?"
when then run with a 32-bit JDK on a 64-bit system.
One other thing is that we should try to include a test with all changes
if possible. I think it should be possible here.
-Alan.
More information about the core-libs-dev
mailing list