Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

Neil Richards neil.richards at ngmr.net
Tue Nov 22 11:51:43 UTC 2011


Hi all,

I've created a webrev [1] to address the problem reported in bug
7094995, where the ClearStaleZipFileInputStreams testcase leaves a
lingering GC inducing thread running after the test ends (when run in
agentvm mode), as spotted by Alan and mentioned in another conversation
[2].

It modifies the testcase so the main thread tells the GcInducingThread
to shut down, and waits for it to do so (using Thread.join()) before
exiting.

I've also converted the testcase's use of ZipFile, ZipOutputStream &
FileOutputStream to use ARM (for greater clarity).

Please let me know your thoughts on this change,

Thanks, Neil

[1] http://cr.openjdk.java.net/~ngmr/7094995/webrev.00/
[2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-November/008251.html

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU




More information about the core-libs-dev mailing list