Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode
Alan Bateman
Alan.Bateman at oracle.com
Tue Nov 22 15:49:08 UTC 2011
On 22/11/2011 11:51, Neil Richards wrote:
> Hi all,
>
> I've created a webrev [1] to address the problem reported in bug
> 7094995, where the ClearStaleZipFileInputStreams testcase leaves a
> lingering GC inducing thread running after the test ends (when run in
> agentvm mode), as spotted by Alan and mentioned in another conversation
> [2].
>
> It modifies the testcase so the main thread tells the GcInducingThread
> to shut down, and waits for it to do so (using Thread.join()) before
> exiting.
>
> I've also converted the testcase's use of ZipFile, ZipOutputStream&
> FileOutputStream to use ARM (for greater clarity).
>
> Please let me know your thoughts on this change,
>
Thanks for coming back to this test. It looks okay to me except I would
change the notify to notifyAll (I assume you decided to use wait/notify
rather than a volatile flag to avoid waiting for the sleep to complete).
-Alan.
More information about the core-libs-dev
mailing list