Code Review 7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use supported compiler interface

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Mon Oct 10 14:02:38 UTC 2011


Approved

Maurizio

On 07/10/11 16:00, Chris Hegarty wrote:
>
> Since the integration of the fix for CR 7094141, it has come to light 
> that the test should be using the supported compiler interface, 
> com.sun.tools.javac.Main. CR 7094141 was a little rushed so that the 
> failing test would not prevent TL integration into the MASTER repo.
>
> There should be less issues with this test going forward after this 
> change.
>
> hg diff sun/misc/JarIndex/metaInfFilenames/Basic.java
> diff -r 24741fe639a8 test/sun/misc/JarIndex/metaInfFilenames/Basic.java
> --- a/test/sun/misc/JarIndex/metaInfFilenames/Basic.java        Tue 
> Oct 04 16:37:08 2011 +0100
> +++ b/test/sun/misc/JarIndex/metaInfFilenames/Basic.java        Fri 
> Oct 07 15:50:18 2011 +0100
> @@ -154,8 +154,8 @@ public class Basic {
>      /* run javac <args> */
>      static void compile(String... args) {
>          debug("Running: javac " + Arrays.toString(args));
> -        com.sun.tools.javac.main.Main compiler = new 
> com.sun.tools.javac.main.Main("javac");
> -        if (compiler.compile(args) != 
> com.sun.tools.javac.main.Main.Result.OK) {
> +        com.sun.tools.javac.Main compiler = new 
> com.sun.tools.javac.Main();
> +        if (compiler.compile(args) != 0) {
>               throw new RuntimeException("javac failed: args=" + 
> Arrays.toString(args));
>          }
>      }
>
>
> -Chris.




More information about the core-libs-dev mailing list