Request for review - change two include header files according to POSIX.1-2008

Charles Lee littlee at linux.vnet.ibm.com
Thu Oct 13 08:03:47 UTC 2011


On 10/13/2011 01:11 PM, David Holmes wrote:
> Hi Charles,
>
> On 13/10/2011 2:54 PM, Charles Lee wrote:
>> Thanks Alan. Below is the patch I am failed to attach. It is trivial...
>
> Do you need someone to sponsor this for you, or are you able to drive 
> this via other IBM folk that can generate webrevs on 
> cr.openjdk.java.net and ultimately do the push?

Neil may help me with generating webrevs on cr.openjdk.java.net.

>
>> By the way, is there any network problem in openjdk these days? I used
>> to attach a webrev successfully, but fail now for many many attempts.
>> The webrev is only 76k big...
>
> I reported this on the web-discuss list and a couple of tweaks have 
> been made to the mailman settings. Can you try again? If it fails can 
> you point me to a posting where you did attach the webrev successfully 
> and then someone will be able to compare the two situations.

Trying to attach the webrev. If fail, please check the thread 
http://mail.openjdk.java.net/pipermail/swing-dev/2011-September/001755.html 
. I used to attach a webrev successfully on the swing-dev mailing list.

>
> Thanks,
> David
>
>> diff --git src/solaris/native/sun/awt/splashscreen/splashscreen_config.h
>> src/solaris/native/sun/awt/splashscreen/splashscreen_config.h
>> index bb03165..e312c2b 100644
>> --- src/solaris/native/sun/awt/splashscreen/splashscreen_config.h
>> +++ src/solaris/native/sun/awt/splashscreen/splashscreen_config.h
>> @@ -32,7 +32,7 @@
>> #include <X11/Xutil.h>
>> #include <X11/extensions/shape.h>
>> #include <sys/types.h>
>> -#include <sys/unistd.h>
>> +#include <unistd.h>
>> #include <pthread.h>
>> #include <signal.h>
>> #include <inttypes.h>
>> diff --git src/solaris/native/sun/nio/fs/genSolarisConstants.c
>> src/solaris/native/sun/nio/fs/genSolarisConstants.c
>> index df46398..346bfbb 100644
>> --- src/solaris/native/sun/nio/fs/genSolarisConstants.c
>> +++ src/solaris/native/sun/nio/fs/genSolarisConstants.c
>> @@ -27,7 +27,7 @@
>> #include <errno.h>
>> #include <unistd.h>
>> #include <sys/acl.h>
>> -#include <sys/fcntl.h>
>> +#include <fcntl.h>
>> #include <sys/stat.h>
>>
>> /**
>> diff --git src/solaris/native/sun/nio/fs/genUnixConstants.c
>> src/solaris/native/sun/nio/fs/genUnixConstants.c
>> index ea48d4d..56984a7 100644
>> --- src/solaris/native/sun/nio/fs/genUnixConstants.c
>> +++ src/solaris/native/sun/nio/fs/genUnixConstants.c
>> @@ -26,7 +26,7 @@
>> #include <stdio.h>
>> #include <errno.h>
>> #include <unistd.h>
>> -#include <sys/fcntl.h>
>> +#include <fcntl.h>
>> #include <sys/stat.h>
>>
>> /**
>>
>


-- 
Yours Charles



More information about the core-libs-dev mailing list