Codereview request for 7096080: UTF8 update and new CESU-8 charset

Alan Bateman Alan.Bateman at oracle.com
Fri Oct 28 16:14:53 UTC 2011


On 28/09/2011 20:18, Xueming Shen wrote:
> Hi,
>
> [I combined the proposed charge for #7082884, in which no one appears 
> to be
> interested:-) into this one]
> :
>
> http://cr.openjdk.java.net/~sherman/7096080/webrev/ 
> <http://cr.openjdk.java.net/%7Esherman/7096080/webrev/>
I don't know if you are still looking for a reviewer for this (seems 
like Ulf has gone through this in detail, thanks Ulf).

Overall it looks fine to me. Minor comment is that in UTF_8.java then 
maybe isMalformed2 should be removed completely, maybe move some of the 
comment in the decode methods. Another minor nits is that the date on 
CESU_8.java is 2000-2010 where I assume it should be 2011. In 
Errors.java then it might be better to just remove L196 as it might 
confuse future maintainers. I would also suggest adding the bugID to the 
list of bugs in the tests too as someone these references are useful.

-Alan.



More information about the core-libs-dev mailing list