Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)
Alan Bateman
Alan.Bateman at oracle.com
Sun Oct 30 14:07:47 UTC 2011
On 28/10/2011 23:44, Darryl Mocek wrote:
> Hello. Please review this patch to add empty sorted set to the
> Collections class. Test case provided.
>
> Webrev: http://cr.openjdk.java.net/~mduigou/4533691/1/webrev/
>
> Additional Notes to Reviewers:
> The sets resulting from tailSet() headSet() and subSet() normally
> include the range which was used to create them. Using these methods
> with emptySortedSet() does not currently set a range on the resulting
> sets.
Just to add to Jason's comment, would it be better to just leave out
EMPTY_SORTED_SET from this patch? It would be nice not to have to load
yet another class when Collections is first used and I assume we would
encourage folks to use Collections.emptySortedSet() anyway so that they
get type safety.
-Alan.
More information about the core-libs-dev
mailing list