Review Request: 7088913/7088952 : Additions to primitive wrappers

joe.darcy at oracle.com joe.darcy at oracle.com
Wed Sep 21 00:03:50 UTC 2011


Hi Mike.

Approved, with a comment.  For cases like Boolean, Double, and Long, I'd 
prefer to see the instance hashCode method rewritten in terms of the new 
static hashCode method.

Cheers,

-Joe

On 9/20/2011 1:11 PM, Mike Duigou wrote:
> Hello all;
>
> Here's a webrev for two small additions to the primitive wrapper types (Boolean, Byte, Character, Double, Float, Integer, Long, Short).
>
>   http://cr.openjdk.java.net/~mduigou/7088913/0/webrev/
>
> The webrev combines two issues:
>
>   7088913: Add compatible static hashCode(primitive) to primitive wrapper classes 
>   7088952: Add "BYTES" constant to primitive wrapper classes
>
> Stuart Marks has already peer reviewed this for me but a sharp eyed reader may catch something previously missed. As it's already been reviewed I will commit on Friday if there is no feedback.
>
> Thanks,
>
> Mike



More information about the core-libs-dev mailing list