Review Request: 7088913/7088952 : Additions to primitive wrappers

David Holmes david.holmes at oracle.com
Wed Sep 21 01:02:21 UTC 2011


Hi Mike,

A minor style nit. In Byte you have:

+    public static final int BYTES = Byte.SIZE / Byte.SIZE;

whereas all the other classes use SIZE / Byte.size

David

On 21/09/2011 6:11 AM, Mike Duigou wrote:
> Hello all;
>
> Here's a webrev for two small additions to the primitive wrapper types (Boolean, Byte, Character, Double, Float, Integer, Long, Short).
>
>    http://cr.openjdk.java.net/~mduigou/7088913/0/webrev/
>
> The webrev combines two issues:
>
>    7088913: Add compatible static hashCode(primitive) to primitive wrapper classes
>    7088952: Add "BYTES" constant to primitive wrapper classes
>
> Stuart Marks has already peer reviewed this for me but a sharp eyed reader may catch something previously missed. As it's already been reviewed I will commit on Friday if there is no feedback.
>
> Thanks,
>
> Mike



More information about the core-libs-dev mailing list