Please review: 7125442

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Tue Jan 10 21:44:47 UTC 2012


> I18NJarTest.java
>    L29: Is -XDignore.symbol.file really needed?  As far as I see,
>            the test only uses the public APIs.

This is needed,  since TestHelper uses javac and tar  apis
behind the scenes.

>    L79: should it check if the returned value is false?

IMO not necessary, if mkdir fails then createJar will throw exception.


>
> Otherwise, looks good.

Thanks
Kumar

>
> Mandy
>
> On 1/10/2012 1:06 PM, Kumar Srinivasan wrote:
>> sorry I pasted the wrong webrev in the email,
>> here is the right one...
>> http://cr.openjdk.java.net/~ksrini/7125442/
>>
>> Kumar
>>
>>
>>
>>> Hi,
>>>
>>> Please review:
>>> CR:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ksrini/7124443/
>>>
>>> Thanks
>>> Kumar
>>>
>>




More information about the core-libs-dev mailing list