Please review: 7125442

[Mandy Chung]

On 1/10/2012 1:44 PM, Kumar Srinivasan wrote:
>
>> I18NJarTest.java
>>    L29: Is -XDignore.symbol.file really needed?  As far as I see,
>>            the test only uses the public APIs.
>
> This is needed,  since TestHelper uses javac and tar  apis
> behind the scenes.

Ah.  I missed its reference to sun.tools.jar.Main.  It uses
javax.tools.ToolProvider and JavaCompiler API and so sun.tools.jar
api is the only one.

>
>>    L79: should it check if the returned value is false?
>
> IMO not necessary, if mkdir fails then createJar will throw exception.
>

Okay.  Thanks.

Mandy