typo in comments of JVM_SupportsCX8 in jvm.h
Chris Hegarty
chris.hegarty at oracle.com
Fri Jun 8 08:44:06 UTC 2012
On 08/06/12 02:51, David Holmes wrote:
> On 8/06/2012 6:39 AM, chris hegarty wrote:
>> Looks fine Kris (given the same change is being made to
>> hotspot/src/share/vm/prims/jvm.h)
>>
>> I can sponsor this for you. We can use the same bug number seeing as
>> these are two separate repositories.
>
> Bzzzt! No you can't!
>
> In theory you can use one CR to cover a combined change across multiple
> repos (eg open and closed).
>
> But you can't use one CR to cover a change in two different components:
> hotspot and jdk. One has to be filed against jvm->hotspot->whatever, the
> other against java->java->whatever.
<Sign> you're right. I was thinking of a similar case across the
langtools and jdk repos.
CR 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h
-Chris.
>
> David
> ----
>
>> -Chris.
>>
>> On 07/06/2012 21:10, Krystal Mok wrote:
>>> Hi all,
>>>
>>> As discussed on hotspot-compiler-dev [1], I came across a typo in the
>>> exported jvm.h in the jdk workspace while working on 7174218.
>>> The fix is simple [2], and sync up with the changes in 7174218:
>>>
>>> diff -r 7def50698e78 src/share/javavm/export/jvm.h
>>> --- a/src/share/javavm/export/jvm.h Thu May 24 16:15:58 2012 -0700
>>> +++ b/src/share/javavm/export/jvm.h Wed Jun 06 01:15:50 2012 +0800
>>> @@ -595,7 +595,7 @@
>>> JVM_AssertionStatusDirectives(JNIEnv *env, jclass unused);
>>>
>>> /*
>>> - * java.util.concurrent.AtomicLong
>>> + * java.util.concurrent.atomic.AtomicLong
>>> */
>>> JNIEXPORT jboolean JNICALL
>>> JVM_SupportsCX8(void);
>>>
>>> Could someone review and sponsor this fix, please?
>>>
>>> Regards,
>>> Kris Mok
>>>
>>> [1]:
>>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2012-June/007798.html
>>>
>>>
>>> [2]:
>>> https://gist.github.com/2876357#file_remove_atomic_long_cs_impl_jdk.patch
>>>
More information about the core-libs-dev
mailing list