Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

[Rémi Forax]

On 06/13/2012 06:18 PM, Joe Wang wrote:
> Hi Lance,
>
> The changes look good to me.
>
> Joe

Hi Lance,
just a minor comment, in isPKNameValid, you don't need the boolean 
isValid because
you can return true instead of using break and return false at the end.

cheers,
Rémi

>
> On 6/13/2012 4:09 AM, Paul Sandoz wrote:
>> On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
>>> Hi Paul,
>>>
>>> Thank you for taking  the time to review the code.
>>>
>>>
>>> I made the change you suggested below
>>>
>>> http://cr.openjdk.java.net/~lancea/7145913/webrev.02
>>>
>>> Let me know if you are good with the change and I will get this 
>>> puppy put back.
>>>
>> Looks good!
>>
>> Paul.