Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

[Lance Andersen - Oracle]

Hi Remi,

Thank you for the suggestion.  Over the years, I have gotten different views on whether to have multiple return points vs just one.

Is there a specific style preference that should be used going forward?  At this time, I   would prefer to not make another change and if the consensus going forward is  that multiple return points is OK, I will make the change in my next push of this code.

Best
Lance
On Jun 13, 2012, at 12:49 PM, Rémi Forax wrote:

> On 06/13/2012 06:18 PM, Joe Wang wrote:
>> Hi Lance,
>> 
>> The changes look good to me.
>> 
>> Joe
> 
> Hi Lance,
> just a minor comment, in isPKNameValid, you don't need the boolean isValid because
> you can return true instead of using break and return false at the end.
> 
> cheers,
> Rémi
> 
>> 
>> On 6/13/2012 4:09 AM, Paul Sandoz wrote:
>>> On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
>>>> Hi Paul,
>>>> 
>>>> Thank you for taking  the time to review the code.
>>>> 
>>>> 
>>>> I made the change you suggested below
>>>> 
>>>> http://cr.openjdk.java.net/~lancea/7145913/webrev.02
>>>> 
>>>> Let me know if you are good with the change and I will get this puppy put back.
>>>> 
>>> Looks good!
>>> 
>>> Paul.
> 
> 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com