Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

[Rémi Forax]

On 06/13/2012 07:01 PM, Lance Andersen - Oracle wrote:
> Hi Remi,
>
> Thank you for the suggestion.  Over the years, I have gotten different 
> views on whether to have multiple return points vs just one.
>
> Is there a specific style preference that should be used going 
> forward?  At this time, I   would prefer to not make another change 
> and if the consensus going forward is  that multiple return points is 
> OK, I will make the change in my next push of this code.
>
> Best
> Lance

I don't want to start another endless debate between single/multiple 
return points.
It's just that most of the code of the JDK, at least after java 2,
is written using the multiple return points style.

rgds,
Rémi

> On Jun 13, 2012, at 12:49 PM, Rémi Forax wrote:
>
>> On 06/13/2012 06:18 PM, Joe Wang wrote:
>>> Hi Lance,
>>>
>>> The changes look good to me.
>>>
>>> Joe
>>
>> Hi Lance,
>> just a minor comment, in isPKNameValid, you don't need the boolean 
>> isValid because
>> you can return true instead of using break and return false at the end.
>>
>> cheers,
>> Rémi
>>
>>>
>>> On 6/13/2012 4:09 AM, Paul Sandoz wrote:
>>>> On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
>>>>> Hi Paul,
>>>>>
>>>>> Thank you for taking  the time to review the code.
>>>>>
>>>>>
>>>>> I made the change you suggested below
>>>>>
>>>>> http://cr.openjdk.java.net/~lancea/7145913/webrev.02 
>>>>> <http://cr.openjdk.java.net/%7Elancea/7145913/webrev.02>
>>>>>
>>>>> Let me know if you are good with the change and I will get this 
>>>>> puppy put back.
>>>>>
>>>> Looks good!
>>>>
>>>> Paul.
>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>