Review/comment needed for the new public java.util.Base64 class

Mike Duigou mike.duigou at oracle.com
Thu Oct 18 20:07:39 UTC 2012


I wonder if there would be advantage in using a SharedSecrets mechanism to allow construction of a String directly from a char array. The intermediate byte array seems wasteful especially for what is likely to be a heavily used path.

Mike

On Oct 17 2012, at 19:10 , Xueming Shen wrote:

> Hi
> 
> Webrev has been updated with following changes
> 
> (1) added a pair of en/decode(ByteBuffer src, ByteBuffer dst) methods
> (2) some minor spec clarification regarding the "end of decoding"
> (3) performance tuning.
> 
> webrev:
> http://cr.openjdk.java.net/~sherman/4235519/webrev
> 
> some performance scores:
> http://cr.openjdk.java.net/~sherman/4235519/score3
> 
> -Sherman




More information about the core-libs-dev mailing list