RFR for JDK-7168267: TEST_BUG: Cleanup of rmi regression tests (activation and others)

[Tristan Yan]

Hi Everyone
Please review the code fix for bug JDK-7168267

http://cr.openjdk.java.net/~tyan/JDK-7168267/webrev.01/ 
<http://cr.openjdk.java.net/%7Etyan/JDK-7168267/webrev.01/>

This is a cleanup for RMI tests. trying to use real timeout to replace a 
fixed number of loop.
Thank you

Tristan


On 12/12/2013 05:33 AM, Stuart Marks wrote:
> On 12/10/13 6:10 PM, Tristan Yan wrote:
>> /Hi everyone
>> I am working on bug JDK-7168267
>>
>
> Correct link is
>
> https://bugs.openjdk.java.net/browse/JDK-7168267
>
>> Root Cause:
>> - Per Stuart's comment, this is a clean up bug.
>>
>> Suggested Fix:
>> - Will use timeout to replace loop.
>
> We should probably look at specific cases for this. There are places 
> where the test is waiting for some external service to become ready 
> (e.g., rmiregistry). There's no notification for things like this so 
> wait-with-timeout cannot be used. Pretty much the only thing that can 
> be done is to poll reasonably often until the service is ready, or 
> until the timeout is exceeded.
>
>> - Also I am fixing two test's performance
>> java/rmi/activation/Activatable/forceLogSnapshot - method 
>> waitAllStarted is
>> using sleep to poll 50 restartedObject to be true, we can use modern
>> CountDownLatch to implement blocking-time wait.
>> java/rmi/activation/Activatable/checkAnnotations - We can subclass
>> ByteArrayOutputStream which support notification when data was 
>> written. Also use
>> two thread wait output string and error string to be not null.
>
> These sound reasonble. Go ahead and file sub-tasks for these and then 
> choose one to work on first. (I think it will get too confusing if we 
> try to work on them all simultaneously.) Either post a detailed 
> description of what you intend to do, or if it's simple enough, just 
> post a webrev.
>
> s'marks
>
>>
>> Please let me know if you have any comments or suggestions.
>> / /
>> Thank you
>> Tristan
>>
>> On 12/05/2013 09:02 AM, Stuart Marks wrote:
>> /
>>> /On 12/3/13 11:05 PM, Tristan Yan wrote:
>>> /
>>>> /I am working on https://bugs.openjdk.java.net/browse/JDK-7168267. 
>>>> This bug is
>>>> asking performance improvement for RMI test. Because this would 
>>>> involve
>>>> different RMI tests. I’d like to use this cr as an umbrella bug, 
>>>> create sub-cr
>>>> for different test. Then I can make progress on sub-cr. Please let 
>>>> me know your
>>>> opinion on this.
>>>> /
>>> /
>>> Actually JDK-7168267 is more about various test cleanups, and 
>>> JDK-8005436 is
>>> more about performance. Both bugs, though, make general statements 
>>> about "the
>>> RMI tests" and don't have much information about specific actions 
>>> that need to
>>> be taken. I've added some notes to JDK-7168267 about some cleanups 
>>> that could
>>> be done.
>>> / /
>>> If there are specific actions for either of these bugs, then yes, 
>>> creating
>>> Sub-Tasks of these bugs and fixing them individually is the right 
>>> thing to do.
>>> / /
>>> s'marks
>>> /
>> /
>> /