RFR: javax.xml.xpath: Using ServiceLoader to load JAXP XPath factories (7169894: JAXP Plugability Layer: using service loader)

[Alan Bateman]

On 11/01/2013 14:27, Daniel Fuchs wrote:
> Hi,
>
> Here is a new webrev in the series that addresses using ServiceLoader in
> JAXP for JDK 8.
>
> 7169894: JAXP Plugability Layer: using service loader
>
> This changeset addresses modification in the javax.xml.xpath
> package.
>
> This changes are very similar to the changes proposed for
> the javax.xml.validation package, except that here we didn't
> need to add a new Error class.
>
> <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.xpath/webrev.00/> 
>
It's great to get the end of these updates.

I looked at the xpath changes and it mostly looks good to me.

As per the validation work, it looks like the isObjectModelSupported 
method will be called twice when assertions are enabled (it's a minor 
concern).

One thing that I don't get is newXPathFactoryNoServiceLoader - maybe 
this is question for Joe but is this means to create the XPathFactory 
documented anywhere, I don't see it in the javadoc.  A minor style 
comment on this is that method declaration looks like odd.

Otherwise I think this is good.

-Alan.