Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream

Lance Andersen - Oracle Lance.Andersen at oracle.com
Thu Jan 31 22:31:37 UTC 2013


+1
On Jan 31, 2013, at 5:15 PM, Xueming Shen wrote:

> Hi,
> 
> Obviously ioe is not an appropriate exception for invalid base64 bytes,
> and it's inconsistent with the rest of decode methods, as the submitter
> suggested.
> The change is to explicitly specify (as other decoding methods do) that
> IAE will be thrown if the input stream contains invalid base64 bytes. The
> impl is also updated according.
> 
> Please help review.
> 
> http://cr.openjdk.java.net/~sherman/8006295/webrev/
> 
> Thanks
> -Sherman

-------------- next part --------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com



More information about the core-libs-dev mailing list