Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream

[Louis Wasserman]

In what way is this "obviously" inappropriate?  (I don't object, I just
don't follow.)


On Thu, Jan 31, 2013 at 2:31 PM, Lance Andersen - Oracle <
Lance.Andersen at oracle.com> wrote:

> +1
> On Jan 31, 2013, at 5:15 PM, Xueming Shen wrote:
>
> > Hi,
> >
> > Obviously ioe is not an appropriate exception for invalid base64 bytes,
> > and it's inconsistent with the rest of decode methods, as the submitter
> > suggested.
> > The change is to explicitly specify (as other decoding methods do) that
> > IAE will be thrown if the input stream contains invalid base64 bytes. The
> > impl is also updated according.
> >
> > Please help review.
> >
> > http://cr.openjdk.java.net/~sherman/8006295/webrev/
> >
> > Thanks
> > -Sherman
>
>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
>
>
>


-- 
Louis Wasserman