RFR (2nd): 8015315: Stream.concat methods

Henry Jen henry.jen at oracle.com
Mon Jul 8 19:42:25 UTC 2013


On 07/04/2013 12:46 AM, Paul Sandoz wrote:
> On Jul 4, 2013, at 9:31 AM, Henry Jen <henry.jen at oracle.com> wrote:
>> Hi,
>>
>> I updated the test, and split the ConcatTest.java so we don't encounter
>> the ClassNotFoundException issue on test-ng.
>>
>> Please review the webrev at
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8015315.1/webrev/
>>
> 
> Looks good. I would like to get this in quickly as it will unblock the F/J patch and others. I can push this for you.
> 

Thanks, that would be great.

> Peter's keen observation on Spliterator characteristics can be addressed as a separate issue.
>

+1. There is a bug tracking this, 8020061.

> I think the remarks on <? extends T> should be also be treated as a separate discussion as it has wider implications.
> 

I agree with you, and had replied on why it is safe.

I did a quick experiment, it would need quite some effort to work out
the type system for various spliterator implementations.

Cheers,
Henry




More information about the core-libs-dev mailing list