Java 8 RFR 8020539: Clean up doclint problems in java.util package, part 2

Joe Darcy joe.darcy at oracle.com
Mon Jul 29 07:05:14 UTC 2013


On 07/18/2013 02:19 PM, Brian Burkhalter wrote:
> On Jul 17, 2013, at 10:07 PM, Joe Darcy wrote:
>
>> In Random.java, I would prefer if the <font> size manipulation of the exponent was removed instead of
>>
>> 373      * All 2<fontstyle="font-size:smaller;"><sup>24</sup></font> possible {@code float} values
>>
>> just
>>
>> 373      * All 2<sup>24</sup> possible {@code float} values.
> Done.
>
>> Also, I think the changes in Scanner would be better of the JLS-style grammar syntax was used, which is what is done in places like java.lang.*. From memory,
>>
>> NonTerminal:
>>     First Option of the production
>>     Second Options of the production
> Changes made but I'm not sure that they are exactly as expected:
>
> http://cr.openjdk.java.net/~bpb/Scanner.html

I recommend a few changes here:

* For readability, rename "NonASCIIDigit" as "NonAsciiDigit"

* Since Scanner is in the regex package, it may be more appropriate to 
stick more of a regex notation than an ebnf notation, but keeping the 
definition list structure tags.

>
>> Offhand, I wasn't aware Dequeue and Queue were maintained in Doug's CVS, but I agree changes to those files should flow through there first.
> Deque and Queue removed from the webrev:
>
> http://cr.openjdk.java.net/~bpb/8020539/
>

Otherwise, the changes look fine. If you like, the non-Scanner changes 
can be split out and pushed first.

Thanks,

-Joe




More information about the core-libs-dev mailing list