Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

Eric McCorkle eric.mccorkle at oracle.com
Sat Jun 1 12:32:55 UTC 2013


Thanks, Kumar.  Do I have a second?

Note: JPRT has been unreliable lately, so it may be a while before I can
put this in.

On 05/30/13 17:45, Kumar Srinivasan wrote:
> Hi Erik,
> 
> This looks good, historically  the #!shell  was inserted after the
> CopyRight,
> because it was thought that the automated CR updaters might get confused.
> 
> I am cc'ing Dave K, just so that he is aware of this.
> 
> Thanks
> Kumar
> 
>> Hello,
>>
>> Please review this simple patch which fixes an issue with several of the
>> shell script tests, namely that they do not start with #!/bin/sh
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~emc/8014834/
>>
>> The bug is here:
>> http://bugs.sun.com/view_bug.do?bug_id=8014834
>>
>> Thanks,
>> Eric
> 


More information about the core-libs-dev mailing list