Review request JDK-8015912: jdeps support to output in dot file format
Alan Bateman
Alan.Bateman at oracle.com
Wed Jun 12 10:41:12 UTC 2013
On 11/06/2013 03:46, Mandy Chung wrote:
> This adds jdeps --format=dot option to print the output in dot-style
> format that can be taken to generate a dependency graph.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.00/
>
> This also extends --verbose option to take an optional argument
> ("class" and "package") to replace the --verbose-level option and
> cleans up PlatformClassPath to use java.nio.file.
This this good, .dot is very useful.
Minor comments PlatformClassPath:
home.resolve("lib").toFile().exists() could also be
Files.exists(home.resolve("lib")).
"if (classes.exists() && classes.isDirectory()) { ... }" can be changed
to "if (classes.isDirectory()) { ... }"
In Profiles.main (debugging only, not used) then you can probably drop
the check for p1 and p2.profile==0 as they aren't needed.
-Alan.
More information about the core-libs-dev
mailing list