Review request JDK-8015912: jdeps support to output in dot file format

[Paul Sandoz]

Hi Mandy,

JdepsTask:

Given that the dot graph output is likely to be just as human readable as your original format it is very tempting just to support that format. In fact it is likely to be more human readable since the output is of a known syntax. So IMHO we don't need a format option and dot graph output is sufficient.

 636             log.format("digraph G {%n");

Perhaps a better name can be chosen for the title of the summary graph?

You don't need to pass in the log PrintWriter to the OutputWriter implementations if they are non-static i.e. sometimes you use "out" and sometimes you use "log".


PlatformClassPath:

  53     static boolean contains(Archive archive) {
  54         return javaHomeArchives.contains(archive) && !archive.getFileName().equals("jfxrt.jar");
  55     }

Just curious: why is the the check for "jfxrt.jar" required?


Profiles:

You might be able to use a lambda expression when creating the comparator for the TreeSet:

  Set<Profile> profiles = new TreeSet<Profile>((p1, p2) -> { ... });

I realize that is just for debugging so it's not really important, but i have lambda goggles on so cannot help it :-)


Paul.

On Jun 11, 2013, at 4:46 AM, Mandy Chung <mandy.chung at oracle.com> wrote:

> This adds jdeps --format=dot option to print the output in dot-style format that can be taken to generate a dependency graph.
> 
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.00/
> 
> This also extends --verbose option to take an optional argument ("class" and "package") to replace the --verbose-level option and cleans up PlatformClassPath to use java.nio.file.
> 
> thanks
> Mandy