RFR 8010325 : Remove hash32() method and hash32 int field from java.lang.String

[Chris Hegarty]

On 12 Jun 2013, at 17:10, Mike Duigou <mike.duigou at oracle.com> wrote:

> Looks good to me.

+1

-Chris


> Mike
> 
> On Jun 11 2013, at 13:32 , Brent Christian wrote:
> 
>> Hi,
>> 
>> Please review my fix for 8010325.  Some background:
>> 
>> The alternative string-hashing implementation[1] added to java.lang.String a new public method, hash32(), as well as a new private int field to cache the alternate hash value.
>> 
>> Following 8005698 [2] and 8005704 [3], the new method and field in String are no longer used.
>> 
>> By updating a couple lines in Hashtable/HashMap/WeakHashMap, the internal sun.misc.Hashing class can also be removed.
>> 
>> The webrev is here:
>> http://cr.openjdk.java.net/~bchristi/8010325/webrev.00/
>> 
>> Thanks,
>> -Brent
>> 
>> 1. http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/43bd5ee0205e
>> 2. http://bugs.sun.com/view_bug.do?bug_id=8005698
>> 3. http://bugs.sun.com/view_bug.do?bug_id=8005704
>