RFR: Lambda 8026213: Reflection support for private methods in interfaces

Remi Forax forax at univ-mlv.fr
Thu Oct 10 09:21:18 UTC 2013


On 10/10/2013 12:13 AM, Karen Kinnear wrote:
> Please review:
>
> webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8026213
>
> Summary:
> Reflection generates code dynamically to speed up reflection processing after startup. The first
> 15 runs of a reflection call  use the vm code path, after that we use the generated code path, which
> needs to use invokespecial on private methods in interfaces.
>
> Tested:
> Test attached to the bug
>
> Also - all the 8011311 private method testing was run with this in the build:
> Robert Field's TypeTest
> 8025475 test
> defmeth privatemethodstest with reflection
> John Rose's intfbug
> jtreg: java.util, java.lang
> jck vm, lang
>
> thanks,
> Karen
>
>

Hi Karen,
the code is Ok for me.

By the way, at some point the comment at the top of emitInvoke() and the 
corresponding test
should be removed because you can not have more than 255/256 parameters 
for a method.

cheers,
Rémi




More information about the core-libs-dev mailing list