RFR: Lambda 8026213: Reflection support for private methods in interfaces

Karen Kinnear karen.kinnear at oracle.com
Thu Oct 10 13:48:06 UTC 2013


Thank you Remi.

I'm actually going to leave the assertion. We are frequently asked to expand limits and
catching this if that time ever happens would make our lives much easier.

thanks,
Karen

On Oct 10, 2013, at 5:21 AM, Remi Forax wrote:

> On 10/10/2013 12:13 AM, Karen Kinnear wrote:
>> Please review:
>> 
>> webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8026213
>> 
>> Summary:
>> Reflection generates code dynamically to speed up reflection processing after startup. The first
>> 15 runs of a reflection call  use the vm code path, after that we use the generated code path, which
>> needs to use invokespecial on private methods in interfaces.
>> 
>> Tested:
>> Test attached to the bug
>> 
>> Also - all the 8011311 private method testing was run with this in the build:
>> Robert Field's TypeTest
>> 8025475 test
>> defmeth privatemethodstest with reflection
>> John Rose's intfbug
>> jtreg: java.util, java.lang
>> jck vm, lang
>> 
>> thanks,
>> Karen
>> 
>> 
> 
> Hi Karen,
> the code is Ok for me.
> 
> By the way, at some point the comment at the top of emitInvoke() and the corresponding test
> should be removed because you can not have more than 255/256 parameters for a method.
> 
> cheers,
> RĂ©mi
> 




More information about the core-libs-dev mailing list