Fwd: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer
Alan Bateman
Alan.Bateman at oracle.com
Tue Sep 17 11:14:59 UTC 2013
On 17/09/2013 11:55, Lance Andersen - Oracle wrote:
> Hi Folks,
>
> Aleksey has been kind enough to review this change. Still need the blessing of a reviewer to put this back...
>
> any takers :-)
It looks okay although if is this is sample code that we expect
developers to copy then we could do more, like taking a defensive copy
of the array. If that is going further than you originally expected then
you can ignore this suggestion.
-Alan.
More information about the core-libs-dev
mailing list