review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer
Lance Andersen - Oracle
Lance.Andersen at oracle.com
Tue Sep 17 11:20:31 UTC 2013
On Sep 17, 2013, at 7:14 AM, Alan Bateman wrote:
> On 17/09/2013 11:55, Lance Andersen - Oracle wrote:
>> Hi Folks,
>>
>> Aleksey has been kind enough to review this change. Still need the blessing of a reviewer to put this back...
>>
>> any takers :-)
> It looks okay although if is this is sample code that we expect developers to copy then we could do more, like taking a defensive copy of the array. If that is going further than you originally expected then you can ignore this suggestion.
No, the intent was just to be a trivial example not to deep dive into things such as defensive copying of the array.
The previous code from the original authors was not even functional :-(
>
> -Alan.
>
-------------- next part --------------
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev
mailing list