JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

Miroslav Kos miroslav.kos at oracle.com
Fri Jan 24 10:50:37 UTC 2014


Hi Chris,
I missed that, sorry. Yes please push it to jdk9, it will do the job 
there too...

Thanks
Miran

On 24/01/14 11:12, Chris Hegarty wrote:
> Miran,
>
> This bug has not been approved for JDK 8, in fact it was considered 
> and rejected. The fix should be pushed to jdk9/dev, if applicable. If 
> the patches apply cleanly I can push it for you. Do you want it in JDK 9?
>
> -Chris.
>
>
> On 24/01/14 09:41, Miroslav Kos wrote:
>> Hi Chris,
>> thanks for reviewing - I generated the patches today again so now it
>> should be ok:
>> http://cr.openjdk.java.net/~mkos/8029237/copyrights-2012-v02.patch
>> http://cr.openjdk.java.net/~mkos/8029237/copyrights-2013-v02.patch
>>
>> Could you push it for me? I have no rights for jdk8.
>>
>> I suppose the commit dates (must be in the past) would be imported
>> correctly:
>>
>> copyrights-2012-v02.patch: -d "2012-12-30"
>> copyrights-2013-v02.patch: -d "2013-12-30"
>>
>> Thanks
>> Miran
>>
>>
>>
>> On 23/01/14 10:07, Chris Hegarty wrote:
>>> On 23 Jan 2014, at 08:53, Martin Grebac <martin.grebac at oracle.com> 
>>> wrote:
>>>
>>>> Hi Miran, did you get any response on this yet?
>>>> MartiNG
>>>>
>>>> On 17/01/14 10:57, Miroslav Kos wrote:
>>>>> Hi Steve and Alan,
>>>>> I just reminding this issue - I have no response from anybody yet
>>>>> and it would really simplify our integration if I could handle
>>>>> copyright years inconsistencies this way - I see this issue in many
>>>>> jdk branches and these "each-branch-different" changes make each
>>>>> integration much more pain.
>>>>>
>>>>> Thanks for any idea on this.
>>>>>
>>>>> Miran
>>>>>
>>>>>
>>>>> On 10/01/14 18:05, Miroslav Kos wrote:
>>>>>> Hi,
>>>>>> this is about fixing copyright years for jdk8 (!); the incorrect
>>>>>> years found for both 2012 and 2013, so not to confuse script
>>>>>> jdk8/make/scripts/update_copyright_year.sh
>>>>>> it is necessary to use option -d "<date>" for commit. I tested that
>>>>>> and it seems to work perfect.
>>>>>> I used following:
>>>>>>
>>>>>> [2012 modifications]
>>>>>> hg commit -u mkos -l ../2012-msg.txt -d "2012-12-30"
>>>>>>
>>>>>> [2013 modifications]
>>>>>> hg commit -u mkos -l ../2013-msg.txt -d "2013-12-30"
>>>>>>
>>>>>> When commits performed with past date, update_copyright_year.sh
>>>>>> script finds those in proper years. Since I am not familiar with
>>>>>> using webrev for pushing changes, I exported both revisions into
>>>>>> separate patches:
>>>>>>
>>>>>> 2012: http://cr.openjdk.java.net/~mkos/8029237/copyrights-2012.patch
>>> I skimmed the patch and it looks ok to me.
>>>
>>> Trivially, it contains a 2013 update (which it should probably be in
>>> the 2013 patch)
>>>
>>> diff -r 91f5c542ccad -r d6aec26c9771 make/Makefile
>>> --- a/make/Makefile    Fri Jan 03 11:54:55 2014 -0800
>>> +++ b/make/Makefile    Sun Dec 30 00:00:00 2012 +0100
>>> @@ -1,5 +1,5 @@
>>>   #
>>> -# Copyright (c) 2012, Oracle and/or its affiliates. All rights 
>>> reserved.
>>> +# Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights
>>> reserved.
>>>   # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>   #
>>>
>>>>>> 2013: http://cr.openjdk.java.net/~mkos/8029237/copyrights-2013.patch
>>> Looks ok to me.
>>>
>>> -Chris.
>>>
>>>>>> all changes webrev:
>>>>>> http://cr.openjdk.java.net/~mkos/8029237/webrev-all.00/ (upload
>>>>>> still in progress, I hope it doesn't take more than 30 mins)
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8029237
>>>>>>
>>>>>> Regards
>>>>>> Miran
>>>>>
>>>>>
>>>> -- 
>>>> Martin Grebac, SW Engineering Manager
>>>> Oracle Czech, Prague
>>>>
>>




More information about the core-libs-dev mailing list