[8011944] Sort fails with ArrayIndexOutOfBoundsException

Miroslaw Niemiec Miroslaw.Niemiec at Oracle.COM
Thu Jan 30 15:36:27 UTC 2014


On 1/30/2014 5:46 AM, Alan Bateman wrote:
> On 30/01/2014 02:34, Miroslaw Niemiec wrote:
>> The copyright header added to 
>> test/java/util/Arrays/TimSortStackSize.java:
>> http://cr.openjdk.java.net/~miroslawzn/8011944/webrev.02/
>>
>> - Miroslaw
> Thanks, just a few minor nits to look at before you push this:
>
> - The import at L30 is mis-aligned.
> - The creation of the Compatator at L49 looks like a new statement, 
> not immediately obvious that it's a parameter to sort (so best to 
> reformat it).
> - The copyright date says 2005 so I assume it was copied from another 
> file.
>
> -Alan
Hi Alan,

I have corrected the test file according to your suggestions
The new webrev:
http://cr.openjdk.java.net/~miroslawzn/8011944/webrev.03/





More information about the core-libs-dev mailing list