[8011944] Sort fails with ArrayIndexOutOfBoundsException

Alan Bateman Alan.Bateman at oracle.com
Thu Jan 30 13:46:42 UTC 2014


On 30/01/2014 02:34, Miroslaw Niemiec wrote:
> The copyright header added to 
> test/java/util/Arrays/TimSortStackSize.java:
> http://cr.openjdk.java.net/~miroslawzn/8011944/webrev.02/
>
> - Miroslaw
Thanks, just a few minor nits to look at before you push this:

- The import at L30 is mis-aligned.
- The creation of the Compatator at L49 looks like a new statement, not 
immediately obvious that it's a parameter to sort (so best to reformat it).
- The copyright date says 2005 so I assume it was copied from another file.

-Alan



More information about the core-libs-dev mailing list