RFR (JAXP): 8035467: Xerces Update: Move to Xalan based DOM L3 serializer. Deprecate Xerces' native serializer.

[huizhe wang]

Hi Lance,

You're right. The original content for deprecation was a copy of that of 
Xerces, which is incorrect for the JDK. What would you think about the 
following:

For DOMSerializerImpl, the main class of the LSSerializer implementation:

@deprecated Replaced by {@link 
com.sun.org.apache.xml.internal.serializer.dom3.LSSerializerImpl}
@since 1.9, Xerces 2.9.0

For all other classes of the LSSerializer implementation:

@deprecated Xerces DOM L3 Serializer implementation is replaced by that 
of Xalan. Main class {@link 
com.sun.org.apache.xml.internal.serialize.DOMSerializerImpl} is replaced 
by {@link com.sun.org.apache.xml.internal.serializer.dom3.LSSerializerImpl}
@since 1.9, Xerces 2.9.0


The original content and recommendation are irrelevant since for JDK, 
this is a change in the internal implementation.

Thanks,
Joe

On 7/29/2014 1:25 PM, Lance Andersen wrote:
> Hi Joe,
>
> For your deprecated methods, would it be reasonable to add an @see or 
> @link to point to public apis that are the replacements?
>
> DOMSerializerImpl has the @deprecated after the @author which you did 
> not do in the other classes.  Would be nice if we can be consistent 
>  if at all possible
>
> Looks fine otherwise.
>
> Best,
> Lance
> On Jul 24, 2014, at 8:39 PM, huizhe wang <huizhe.wang at oracle.com 
> <mailto:huizhe.wang at oracle.com>> wrote:
>
>> Hi all,
>>
>> This is part of Xerces update: move to a common serialization 
>> codebase with Xalan. As noted in one of the mailing list discussions:
>>
>> Xalan's serializer has the same baseline capability as Xerces' Java 
>> serializer, effort was devoted to improve its performance
>> and fix bugs and it is being maintained by Xalan-J community and so 
>> we should use Xalan's serializer as the primary code base moving forward.
>>
>>
>> The main code changes are a new set of classes in "dom3" added to the 
>> serializer package.
>>
>> After fixing a few compatibility issues related to the pretty-print 
>> feature, the patch now passes all of the JAXP tests.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8035467
>>
>> Webrev:
>> http://cr.openjdk.java.net/~joehw/jdk9/8035467/webrev/ 
>> <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8035467/webrev/>
>>
>> Please review.
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>