JDK 9 RFR of 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

Joe Darcy joe.darcy at oracle.com
Fri May 23 19:01:34 UTC 2014


Hello,

Please review the patch below to address

     8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

diff -r f142c0938978 src/solaris/classes/java/lang/UNIXProcess.java
--- a/src/solaris/classes/java/lang/UNIXProcess.java    Fri May 23 
09:05:24 2014 -0700
+++ b/src/solaris/classes/java/lang/UNIXProcess.java    Fri May 23 
11:59:34 2014 -0700
@@ -97,6 +97,7 @@
                  EnumSet.copyOf(Arrays.asList(launchMechanisms));
          }

+        @SuppressWarnings("fallthrough")
          private String helperPath(String javahome, String osArch) {
              switch (this) {
                  case SOLARIS:

The code of the switch in question is

                 case SOLARIS:
                     if (osArch.equals("x86")) { osArch = "i386"; }
                     else if (osArch.equals("x86_64")) { osArch = "amd64"; }
                     // fall through...
                 case LINUX:
                 case AIX:
                     return javahome + "/lib/" + osArch + "/jspawnhelper";

Thanks,

-Joe



More information about the core-libs-dev mailing list