JDK 9 RFR of 8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java

[Lance Andersen]

+1
On May 23, 2014, at 3:01 PM, Joe Darcy <joe.darcy at oracle.com> wrote:

> Hello,
> 
> Please review the patch below to address
> 
>    8043916: Fix fallthrough lint warnings in java/lang/UNIXProcess.java
> 
> diff -r f142c0938978 src/solaris/classes/java/lang/UNIXProcess.java
> --- a/src/solaris/classes/java/lang/UNIXProcess.java    Fri May 23 09:05:24 2014 -0700
> +++ b/src/solaris/classes/java/lang/UNIXProcess.java    Fri May 23 11:59:34 2014 -0700
> @@ -97,6 +97,7 @@
>                 EnumSet.copyOf(Arrays.asList(launchMechanisms));
>         }
> 
> +        @SuppressWarnings("fallthrough")
>         private String helperPath(String javahome, String osArch) {
>             switch (this) {
>                 case SOLARIS:
> 
> The code of the switch in question is
> 
>                case SOLARIS:
>                    if (osArch.equals("x86")) { osArch = "i386"; }
>                    else if (osArch.equals("x86_64")) { osArch = "amd64"; }
>                    // fall through...
>                case LINUX:
>                case AIX:
>                    return javahome + "/lib/" + osArch + "/jspawnhelper";
> 
> Thanks,
> 
> -Joe



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com