RFR (XS) 8060485: (str) contentEquals checks the String contents twice on mismatch
Martin Buchholz
martinrb at google.com
Tue Oct 14 16:33:42 UTC 2014
Looks good to me!
On Tue, Oct 14, 2014 at 9:05 AM, Aleksey Shipilev <
aleksey.shipilev at oracle.com> wrote:
> Hi,
>
> Please review a trivial change in String.contentEquals:
> https://bugs.openjdk.java.net/browse/JDK-8060485
> http://cr.openjdk.java.net/~shade/8060485/webrev.00/
>
> It improves the performance drastically:
> http://cr.openjdk.java.net/~shade/8060485/perf.txt
>
> ...not to mention it improves the code readability, and protects us from
> rogue CharSequence-s.
>
> Testing: microbenchmarks, jdk/test/String* jtreg.
>
> Thanks,
> -Aleksey.
>
>
More information about the core-libs-dev
mailing list