RFR (XS) 8060485: (str) contentEquals checks the String contents twice on mismatch

Chris Hegarty chris.hegarty at oracle.com
Tue Oct 14 17:13:54 UTC 2014


On 14 Oct 2014, at 17:33, Martin Buchholz <martinrb at google.com> wrote:

> Looks good to me!

+1   'noreg-hard'

-Chris.

> On Tue, Oct 14, 2014 at 9:05 AM, Aleksey Shipilev <
> aleksey.shipilev at oracle.com> wrote:
> 
>> Hi,
>> 
>> Please review a trivial change in String.contentEquals:
>>  https://bugs.openjdk.java.net/browse/JDK-8060485
>>  http://cr.openjdk.java.net/~shade/8060485/webrev.00/
>> 
>> It improves the performance drastically:
>>  http://cr.openjdk.java.net/~shade/8060485/perf.txt
>> 
>> ...not to mention it improves the code readability, and protects us from
>> rogue CharSequence-s.
>> 
>> Testing: microbenchmarks, jdk/test/String* jtreg.
>> 
>> Thanks,
>> -Aleksey.
>> 
>> 




More information about the core-libs-dev mailing list