RFR: 8058887: (fmt) Improve java/util/Formatter test coverage of group separators and width

Claes Redestad claes.redestad at oracle.com
Mon Sep 22 19:02:37 UTC 2014


Hi,

previous attempt was considered too trivial a fix, so how about actually 
improving the test coverage, fixing the link issue in genBasic and 
upgrade Spp.java to not add thousands of empty lines while we're at it? 
Rejoice!

webrev: http://cr.openjdk.java.net/~redestad/8058887/webrev.03/

Most relevant files to review are:

http://cr.openjdk.java.net/~redestad/8058887/webrev.03/test/java/util/Formatter/Basic-X.java.template.udiff.html
http://cr.openjdk.java.net/~redestad/8058887/webrev.03/make/src/classes/build/tools/spp/Spp.java.udiff.html
http://cr.openjdk.java.net/~redestad/8058887/webrev.03/test/java/util/Formatter/genBasic.sh.udiff.html

... while the others are generated from the update Spp.java tool using 
the fixed genBasic.sh.

/Claes

On 09/22/2014 04:35 PM, Claes Redestad wrote:
> Hi,
>
> can I have a review and sponsor for this trivial fix to make the jtreg 
> test generator script jdk/test/java/util/Formatter/genBasic.sh work in 
> the new build system?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8058887
> webrev: http://cr.openjdk.java.net/~redestad/8058887/webrev.01/
>
> /Claes




More information about the core-libs-dev mailing list