JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis
David Holmes
david.holmes at oracle.com
Fri Aug 14 02:19:13 UTC 2015
On 14/08/2015 7:42 AM, Joseph D. Darcy wrote:
> Hi David,
>
> On 8/13/2015 2:30 PM, David Holmes wrote:
>> Joe,
>>
>> This is making it hard to clean up everything at once. I'm already
>> delayed from pushing the fix because the "@key intermittent" change is
>> not in hs-rt yet.
>
> If the test needs to be updated as part of the fix for JDK-8029453,
> presumably it should be a trivial merge with the "intermittent" change
> if it doesn't arrive at the same time. If the intermittent-ness give a
> false positive for a while, I think that is acceptable given how changes
> flow around. (The reversal of just the intermittent tag could also be
> done in dev directly after any HotSpot changes for JDK-8029453 get
> integrated into dev.)
The intended change is to remove the intermittent tag as it should no
longer be an intermittent failure. But of course I can't remove the tag
until the change that adds it turns up in my repo.
>> If this change also goes in then I again have to wait for it to arrive
>> before I can reverse it. It will take a month for everything to get
>> back to where it should be. :(
>
> If the HotSpot repos don't pull down this change promptly, I think it is
> fine if the problem list is updated after the HotSpot fix gets into dev.
>
> My main concern here is not have have the test intermittently failing in
> the testing of dev for several more weeks.
Ok. I'm pushing the fix now so that it will hit dev in two weeks time.
I've filed:
https://bugs.openjdk.java.net/browse/JDK-8133611
to remove it from the problem list and remove the intermittent tag once
it hits dev - and I'll push that directly to dev as you suggest.
Thanks,
David
> Thanks,
>
> -Joe
>
>> This also seems to defeat the purpose of adding the "intermittent" tag.
>>
>> David
>>
>> On 14/08/2015 7:18 AM, joe darcy wrote:
>>> Hello,
>>>
>>> Until a fix for JDK-8029453 is in place, the test TimeoutLockLoops.java
>>> should be placed on the problem list for Linux since it fails
>>> intermittently, but fairly frequently, on that OS:
>>>
>>> --- a/test/ProblemList.txt Thu Aug 13 09:36:14 2015 -0700
>>> +++ b/test/ProblemList.txt Thu Aug 13 14:14:39 2015 -0700
>>> @@ -353,6 +353,10 @@
>>> # 8062512
>>> java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.java
>>> generic-all
>>>
>>> +# 8029453
>>> +java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java
>>> linux-all
>>> +
>>> +
>>> ############################################################################
>>>
>>>
>>> # jdk_instrument
>>>
>>> Thanks,
>>>
>>> -Joe
>
More information about the core-libs-dev
mailing list