RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

[Lance Andersen]

On Aug 25, 2015, at 2:36 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 25/08/2015 19:29, Lance Andersen wrote:
>> Hi,
>> 
>> Looking for a reviewer for 8134426   This change adds a serialVersionUID field to the required javax.transaction classes as well as some basic tests.
>>  Once approved,  I will work to push the same changes to the relevant JTA project working with the Java EE team
>> 
>> output from serialver:
>> 
>> ----------------
>> jdk 1.6 (OSX)
>> 
>> serialver -classpath classes.jar javax.transaction.InvalidTransactionException
>> javax.transaction.InvalidTransactionException:    private static final long serialVersionUID = 3597320220337691496L;
>> ljanders-mac:Classes ljanders$ serialver -classpath classes.jar javax.transaction.TransactionRequiredException
>> javax.transaction.TransactionRequiredException:    private static final long serialVersionUID = -1898806419937446439L;
>> ljanders-mac:Classes ljanders$ serialver -classpath classes.jar javax.transaction.TransactionRolledbackException
>> javax.transaction.TransactionRolledbackException:    private static final long serialVersionUID = -3142798139623020577L;
>> 
>> java ee 6
>> 
>>  serialver -classpath javaee.jar javax.transaction.InvalidTransactionException
>> javax.transaction.InvalidTransactionException:    private static final long serialVersionUID = 3597320220337691496L;
>> ljanders-mac:lib ljanders$ serialver -classpath javaee.jar javax.transaction.TransactionRequiredException
>> javax.transaction.TransactionRequiredException:    private static final long serialVersionUID = -1898806419937446439L;
>> ljanders-mac:lib ljanders$ serialver -classpath javaee.jar javax.transaction.TransactionRolledbackException
>> javax.transaction.TransactionRolledbackException:    private static final long serialVersionUID = -3142798139623020577L;
>> ---------------
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/8134426/webrev/.
>> 
> The serialVersionUID update looks okay.
> 
> I have not looked at the tests in detail but the new TEST.properties looks like it's reaching into the /java/sql tree. Should the tests for the JTA not having their own BaseTest that doesn't depend on SQL?

I could do that, but just tried to keep duplicate code down as it only uses BaseTest.java.  I don't have a real strong preference.  Let me know if you feel strongly that I should do so.
> 
> -Alan



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com